Skip to content

Conversation

@santteegt
Copy link
Contributor

Summary

This PR introduces the following updates to AppService to be compatible with rocketpool v.1.18.1 release:

  • Updates the node can-set-withdrawal-address cmd to node can-set-primary-withdrawal-address
  • Updates the node can-deposit amount min-fee salt cmd to api node can-deposit amount min-fee salt use-express-ticket and sets the use-express-ticket argument to false by default
  • Updates the node deposit amount min-node-fee salt use-credit-balance submit cmd to node deposit amount min-node-fee salt use-credit-balance use-express-ticket submit and sets the use-express-ticket argument to false by default
  • Code cleanup: deletes the getNodeCanRegister() function and the NodeCanRegister.ts type, as these were not being used (frontend always uses the canRegisterNode() function).

Special request

👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇
Please add the hacktoberfest-accepted label to this PR before merging so it counts as an open source contribution to this year's Hacktoberfest 🙏
👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆

@mgarciate mgarciate added the hacktoberfest-accepted https://hacktoberfest.com label Oct 30, 2025
Copy link
Collaborator

@mgarciate mgarciate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks 🚀

@mgarciate mgarciate merged commit c69b52b into dappnode:main Oct 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted https://hacktoberfest.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants